This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libc x86-64 __thread fix

From: Roland McGrath <roland at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>,Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 14 Oct 2002 16:13:10 -0700
Subject: Re: [PATCH] libc x86-64 __thread fix

> Actually, maybe just the #include <tls.h> is needed.

Yes, though that doesn't directly affect the build of the rtld modules.

> The problem was that without including tls.h uname.os etc. in libc-pic.a

Ah, I see.  I was confused as to how it could be losing even if
USE___THREAD was never defined at all, because !defined -> 0 is the right
default for the rtld build.  But that explains it, since it was the libc
build of the module that indirectly loused up the rtld build.

> Though IMHO putting RTLD_PRIVATE_ERRNO case before USE__THREAD
> shouldn't hurt.

Certainly.  I just don't like these things to be mysterious.

References:
- Re: [PATCH] libc x86-64 __thread fix
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]