This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix resolver option rotate

On Tue, 2002-05-21 at 10:17, Jakub Jelinek wrote:
>
> 2002-05-21  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* resolv/resolv.h (struct __res_state): Remove unused nstimes.
> 	Add nsmap.
> 	* resolv/res_init.c (__res_vinit): Initialize nsmap array.
> 	Remove nstimes setting.
> 	(res_nclose): Check all MAXNS nameservers with non-NULL nsaddrs.
> 	* resolv/res_send.c (res_nsend): Don't close unconditionally if
> 	there is mix of IPv6 and IPv4 nameservers.
> 	Use nsmap array to find free slots and preserve nameserver ordering.
> 	Fix RES_ROTATE.

I've applied this patch.  From what I've seen it makes sense but I
cannot be sure without testing.  And nobody is going to test unless its
applied.  So, let's get it on now.

I won't apply the patch to the 2.2 branch.  Not having this option
correctly implemented is no big deal.  Applying the patch is too risky
for that little gain.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Attachment: signature.asc
Description: This is a digitally signed message part

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]