This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix some warnings



I've committed the appended patch to get rid of some warnings.

Andreas

2001-12-21  Andreas Jaeger  <aj@suse.de>

	* elf/dblloadmod1.c: Add prototype to avoid warning.
	* elf/dblloadmod2.c: Likewise.
	* elf/dblloadmod3.c: Likewise.
	* elf/reldepmod5.c: Likewise.
	* elf/reldepmod6.c: Likewise.

	* elf/dl-conflict.c (_dl_resolve_conflicts): Add unused attribute
	for resolve_conflict_map since RESOLVE_CONFLICT_FIND_MAP is not
	used on all architectures.

	* sunrpc/svc_tcp.c: Add noreturn attribute for
	svctcp_rendezvous_abort.
	* sunrpc/svc_unix.c: Likewise for svcunix_rendezvous_abort.

	* sysdeps/generic/strstr.c (strstr): Add paranthese for assignment
	to avoid warning.

============================================================
Index: sysdeps/generic/strstr.c
--- sysdeps/generic/strstr.c	2001/12/14 22:16:21	1.13
+++ sysdeps/generic/strstr.c	2001/12/21 10:15:23
@@ -49,7 +49,7 @@
 
   haystack = (const unsigned char *) phaystack;
 
-  if (b = *(needle = (const unsigned char *) pneedle))
+  if ((b = *(needle = (const unsigned char *) pneedle)))
     {
       chartype c;
       haystack--;		/* possible ANSI violation */
============================================================
Index: sunrpc/svc_tcp.c
--- sunrpc/svc_tcp.c	2001/08/22 16:58:57	1.21
+++ sunrpc/svc_tcp.c	2001/12/21 10:15:26
@@ -82,7 +82,7 @@
  */
 static bool_t rendezvous_request (SVCXPRT *, struct rpc_msg *);
 static enum xprt_stat rendezvous_stat (SVCXPRT *);
-static void svctcp_rendezvous_abort (void);
+static void svctcp_rendezvous_abort (void) __attribute__ ((__noreturn__));
 
 /* This function makes sure abort() relocation goes through PLT
    and thus can be lazy bound.  */
============================================================
Index: sunrpc/svc_unix.c
--- sunrpc/svc_unix.c	2001/08/22 16:58:57	1.17
+++ sunrpc/svc_unix.c	2001/12/21 10:15:26
@@ -78,7 +78,7 @@
  */
 static bool_t rendezvous_request (SVCXPRT *, struct rpc_msg *);
 static enum xprt_stat rendezvous_stat (SVCXPRT *);
-static void svcunix_rendezvous_abort (void);
+static void svcunix_rendezvous_abort (void) __attribute__ ((__noreturn__));
 
 /* This function makes sure abort() relocation goes through PLT
    and thus can be lazy bound.  */
============================================================
Index: elf/dl-conflict.c
--- elf/dl-conflict.c	2001/12/12 00:05:26	1.1
+++ elf/dl-conflict.c	2001/12/21 10:15:26
@@ -54,7 +54,9 @@
     (map) = resolve_conflict_map;				\
   } while (0)
 
-    struct link_map *resolve_conflict_map = _dl_loaded;
+    struct link_map *resolve_conflict_map __attribute__ ((__unused__))
+      = _dl_loaded;
+    
 
 #include "dynamic-link.h"
 
============================================================
Index: elf/dblloadmod1.c
--- elf/dblloadmod1.c	2001/09/06 01:01:32	1.1
+++ elf/dblloadmod1.c	2001/12/21 10:15:26
@@ -1,4 +1,5 @@
 extern int bar (void);
+extern int foo (void);
 
 int
 foo (void)
============================================================
Index: elf/dblloadmod2.c
--- elf/dblloadmod2.c	2001/09/06 01:01:32	1.1
+++ elf/dblloadmod2.c	2001/12/21 10:15:26
@@ -1,4 +1,6 @@
 extern int bar (void);
+extern int baz (void);
+extern int xyzzy (void);
 
 int
 baz (void)
============================================================
Index: elf/dblloadmod3.c
--- elf/dblloadmod3.c	2001/09/06 01:01:33	1.1
+++ elf/dblloadmod3.c	2001/12/21 10:15:26
@@ -1,3 +1,4 @@
+extern int bar (void);
 extern int baz (void);
 
 int
============================================================
Index: elf/reldepmod5.c
--- elf/reldepmod5.c	2001/09/08 16:25:56	1.1
+++ elf/reldepmod5.c	2001/12/21 10:15:26
@@ -1,3 +1,5 @@
+extern int foo (void);
+
 int
 foo (void)
 {
============================================================
Index: elf/reldepmod6.c
--- elf/reldepmod6.c	2001/09/08 16:25:56	1.1
+++ elf/reldepmod6.c	2001/12/21 10:15:26
@@ -1,4 +1,5 @@
 extern int call_me (void);
+extern int bar (void);
 
 int
 bar (void)

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]