This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: ldconfig bug


Andreas Schwab <schwab@suse.de> writes:

> This makes ldconfig working again.
> 
> Andreas.
> 
> 2001-06-13  Andreas Schwab  <schwab@suse.de>
> 
> 	* elf/ldconfig.c (search_dir): Fix check for regular file.
> 
> --- elf/ldconfig.c.~1.21.~	Fri May 18 11:12:20 2001
>+++ elf/ldconfig.c	Wed Jun 13 20:17:25 2001
> @@ -720,7 +720,7 @@
>  	  add_single_dir (new_entry, 0);
>  	  continue;
> 	}
> -      else if (!S_ISREG (stat_buf.st_mode) && !is_link)
>+      else if (!S_ISREG (lstat_buf.st_mode) && !is_link)

I prefer to switch the conditions:
      else if (!is_link && !S_ISREG (stat_buf.st_mode))

Please commit this,

Andreas

>  	continue;
>  
>        if (opt_chroot && is_link)

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]