This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix MBS regex

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] Fix MBS regex
From: Ulrich Drepper <drepper at redhat dot com>
Date: 15 Feb 2001 13:25:16 -0800
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <20010215221157.K768@sunsite.ms.mff.cuni.cz>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> The issue is that regex was badly inconsistent in translating, PATFETCH
> used to translate even wchar_ts below and equal to '\xff' while TRANSLATE
> only translated chars, so in the testcase start_range_char was translated
> while range_end was not (because sizeof(p[0]) > 1) - I wondered why even at
> -O0 start_range variable does not exist on ia64 in the debugger and the
> reason seems it was an alias for start_range_char.

Extremely cool.  Thanks, it works for me (without further
regressions).  I've added the patch and the test case.

> Are there any regression tests for regex's in other packages (I mean sed,
> awk, perl, whatever)?

None of these packages uses normally the glibc regex.  Grep and sed
hopefully will do soon again, but perl has it only implementation.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

References:
- [PATCH] Fix MBS regex
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]