This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Ressurect __strtou?q_internal


On Sun, Feb 11, 2001 at 09:55:53PM +0100, Jakub Jelinek wrote:
> Hi!
> 
> Those two aliases were unfortunately exported from libc and according to
> http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=27029
> IBM DB2 6.1 from IBM Websphere 3.5 was linked against it.
> It looks like some inlines (strtou?q, strtou?ll) used to be defined to
> __strtou?q_internal at least in 1996 and early 1997.
> So, IMHO no matter whether they are unused now, they should be present for
> binary compatibility.
> 
> 2001-02-11  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* sysdeps/generic/strtoll.c (__strtoq_internal): Ressurect alias
> 	which was exported from libc.
> 	* sysdeps/generic/strtoull.c (__strtouq_internal): Likewise.
> 
> --- libc/sysdeps/generic/strtoll.c.jj	Fri Jan  5 22:58:21 2001
> +++ libc/sysdeps/generic/strtoll.c	Sun Feb 11 22:47:21 2001
> @@ -21,4 +21,5 @@
>  
>  #include <strtol.c>
>  
> +strong_alias (__strtoll_internal, __strtoq_internal)
>  weak_alias (strtoll, strtoq)
> --- libc/sysdeps/generic/strtoull.c.jj	Fri Jan  5 22:58:21 2001
> +++ libc/sysdeps/generic/strtoull.c	Sun Feb 11 22:47:21 2001
> @@ -22,5 +22,6 @@
>  #include <strtoul.c>
>  
>  #ifdef _LIBC
> +strong_alias (__strtoull_internal, __strtouq_internal)
>  weak_alias (strtoull, strtouq)
>  #endif
> 
> 
> 	Jakub

You may need to add them to stdlib/Versions.

-- 
H.J. Lu (hjl@valinux.com)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]