This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix gencat (take 2)

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] Fix gencat (take 2)
From: Ulrich Drepper <drepper at redhat dot com>
Date: 16 Dec 2000 00:47:13 -0800
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <20001213145919.D642@sunsite.ms.mff.cuni.cz><20001213155650.F642@sunsite.ms.mff.cuni.cz>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> y = obstack_alloc (x, n);
> ...
> obstack_free (x, y);
> z = obstack_alloc (x, m);
> that if m <= n, then z == y.

Writing like this only calls for errors.  Why don't use simply use

  obstack_blank (x, y);
  ...
  obstack_blank (x, m - y);
  z = obstack_finish (x);

This will always work.  I'll try to handle your patch this way in case
you don't beat me.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Follow-Ups:
- [PATCH] Fix gencat (take 3)
  - From: Jakub Jelinek

References:
- [PATCH] Fix gencat
  - From: Jakub Jelinek
- [PATCH] Fix gencat (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]