This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [ia64-tools] Re: Re: ia64 fenv patch.

To: ia64-tools at napali dot hpl dot hp dot com
Subject: Re: [ia64-tools] Re: Re: ia64 fenv patch.
From: Jes Sorensen <jes at linuxcare dot com>
Date: 22 Sep 2000 11:16:22 +0200
Cc: GNU C Library <libc-hacker at sourceware dot cygnus dot com>
References: <20000920190828.A11605@valinux.com> <200009210851.e8L8piF25186@hawking.suse.de> <20000921072447.A1382@valinux.com>

>>>>> "HJ" == H J Lu <hjl@valinux.com> writes:

HJ> On Thu, Sep 21, 2000 at 10:51:44AM +0200, Andreas Schwab wrote:
>> What's wrong with this?  Both expressions are equivalent.
>> 

HJ> I have so many problems with those functions. I just copied them
HJ> from ia32 :-(. Also it looks nicer :-).

There was a reason why I put in most of the type casts in the
beginning, you have to make sure that the C manipulations do not play
the default truncate to int size.

You claim in your patch that the logic was wrong - could you try and
explain what was actually wrong instead of just saying something was
wrong? It's somewhat hard to judge a patch if you don't try and tell
us what it is trying to solve.

Jes

Follow-Ups:
- Re: [ia64-tools] Re: Re: ia64 fenv patch.
  - From: H . J . Lu

References:
- ia64 fenv patch.
  - From: H . J . Lu
- Re: ia64 fenv patch.
  - From: Andreas Schwab
- Re: [ia64-tools] Re: ia64 fenv patch.
  - From: H . J . Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]