This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Why change posix/globtest.sh?

"H . J . Lu" <hjl@lucon.org> writes:

>  ${elf_objpfx}${rtld_installed_name} --library-path ${library_path} \
>  ${common_objpfx}posix/globtest -q -t "$testdir" "~"$USER |
>  sort > $testout
> -eval echo ~$USER | cmp - $testout || result=1
> +# Some shell incorrectly(?) convert ~/ into // if ~ expands to /.
> +if test ~/ = //; then
> +    echo / | cmp - $testout || result=1
> +else
> +    echo ~/ | cmp - $testout || result=1
> +fi
> 
> UIlrich, I believe you applied the patch at the wrong place. Could
> you please fix it?

Why should this be wrong?  Some shells expand ~/ for $HOME == / to //.
We expect / and therefore we have to have a special test.

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]