This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] One more Sparc fix


On Thu, Apr 06, 2000 at 01:30:22PM +0200, Thorsten Kukuk wrote:
> 
> Hi,
> 
> On Thu, Apr 06, Jakub Jelinek wrote:
> 
> > Hi!
> > 
> > One further thing which popped up at the very end of build after I've sent
> > the last patch. bits/sigcontext.h is unprotected against multiple inclusion
> > so when somebody includes signal.h together with register-dump.h,
> > compilation fails.
> 
> Do we need <bits/sigcontext.h> or <signal.h> in register-dump.h ?
> In my local tree, I have removed this includes, and it compiles
> and seems to work. (But it this is from a backport to 2.1.3).

As segfault.c which is the only one which includes register-dump.h now
includes signal.h it is not necessary, yes. I put it there so that it is
clear that header depends on signal.h but as i386 does not have that include
there and implicitely assumes it as well, the following patch could be
better:

2000-04-06  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h: Don't
	include bits/sigcontext.h.
	* sysdeps/unix/sysv/linux/sparc/sparc64/register-dump.h: Likewise.

--- libc/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h.jj	Mon Jan 17 07:58:55 2000
+++ libc/sysdeps/unix/sysv/linux/sparc/sparc32/register-dump.h	Thu Apr  6 10:15:56 2000
@@ -20,7 +20,6 @@
 
 #include <sys/uio.h>
 #include <stdio-common/_itoa.h>
-#include <bits/sigcontext.h>
 
 /* We will print the register dump in this format:
 
--- libc/sysdeps/unix/sysv/linux/sparc/sparc64/register-dump.h.jj	Fri Dec 10 15:15:34 1999
+++ libc/sysdeps/unix/sysv/linux/sparc/sparc64/register-dump.h	Thu Apr  6 10:09:18 2000
@@ -20,7 +20,6 @@
 
 #include <sys/uio.h>
 #include <stdio-common/_itoa.h>
-#include <bits/sigcontext.h>
 
 /* We will print the register dump in this format:
 

	Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]