Why this strange change?
H.J. Lu
hjl@lucon.org
Sun Jun 27 21:55:00 GMT 1999
Hi, Ulrich,
Your change
1999-06-17 Ulrich Drepper <drepper@cygnus.com>
* nss/getXXbyYY_r.c: Return error code not -1.
* nss/getXXent_r.c: Likewise.
breaks glibc and Linux very badly. Any codes like
if (getXXbyYY_r (......) < 0)
now don't work anymore since now getXXbyYY_r () returns errno which is
a positive number. Did you mean to return NAGATIVE of the error code?
Could you please double check all of your similar changes and fix them?
BTW, even if you can change all of
if (getXXbyYY_r (......) < 0)
in glibc, how do you change all the user codes? I am not sure it is a
good idea to make a change like that. You changed ABI in fact.
Thanks.
--
H.J. Lu (hjl@gnu.org)
More information about the Libc-hacker
mailing list