This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] shut up warnings in bits/string2.h

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] shut up warnings in bits/string2.h
From: Richard Henderson <rth at twiddle dot net>
Date: Tue, 7 Dec 1999 18:41:20 -0800
Cc: drepper at cygnus dot com, libc-hacker at sourceware dot cygnus dot com
References: <19991207220811.M515@mff.cuni.cz>

On Tue, Dec 07, 1999 at 10:08:11PM +0100, Jakub Jelinek wrote:
> 	* string/bits/string2.h (__memset_gc, __mempcpy_small, __strcpy_small,
> 	__stpcpy_small): Cast switch expressions to int to shut up compiler
> 	warnings.

The patch is wrong Jakub.  Suppose you have a string of
length 0x1_0000_0001.  You will truncate this to 1 and
do the wrong thing.

I know you are trying to silence the extra warnings from
gcc's -Wtraditional, but there's nothing to be done about
it except possibly nuking it from the compiler.

r~

References:
- [PATCH] shut up warnings in bits/string2.h
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]