This is the mail archive of the
libc-hacker@sourceware.cygnus.com
mailing list for the glibc project.
sigsuspend -> __sigsuspend
- To: GNU libc hacker <libc-hacker@gnu.org>
- Subject: sigsuspend -> __sigsuspend
- From: Roland McGrath <roland@frob.com>
- Date: Sun, 19 Jul 1998 19:10:32 -0400
This change was made solely on linux:
Wed Nov 20 02:04:11 1996 Ulrich Drepper <drepper@cygnus.com>
* sysdeps/unix/sysv/linux/sigsuspend.c: Make sigsuspend a weak
alias of __sigsuspend.
It's annoying that you didn't bother to update all the other
sysdeps/.../sigsuspend.c versions, since it's so trivial. It's an easy
thing to do when you make a change like this (just use M-x find-dired on in
sysdeps for -name sigsuspend.c, like I did just now), and really eases the
bit-rot burden when trying to revive ports. Of course a few things will
always slip through the cracks, but I always tried to be conscientious
about this, and the apparent complete lack of effort is disappointing.
I hope everyone will please try to remember to take the extra minute when
making such changes in the future.
Thanks,
Roland
Here are fixes to the neglected files:
1998-07-19 Roland McGrath <roland@baalperazim.frob.com>
* sysdeps/posix/sigsuspend.c: Define __sigsuspend with sigsuspend as
a weak alias.
* sysdeps/mach/hurd/sigsuspend.c: Likewise.
* sysdeps/generic/sigsuspend.c: Likewise.
Index: sysdeps/posix/sigsuspend.c
===================================================================
RCS file: /egcs/carton/cvsfiles/libc/sysdeps/posix/sigsuspend.c,v
retrieving revision 1.4
diff -u -r1.4 sigsuspend.c
--- sigsuspend.c 1997/06/23 21:52:35 1.4
+++ sigsuspend.c 1998/07/19 23:03:45
@@ -1,4 +1,4 @@
-/* Copyright (C) 1991, 1996, 1997 Free Software Foundation, Inc.
+/* Copyright (C) 1991, 96, 97, 98 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -25,7 +25,7 @@
/* Change the set of blocked signals to SET,
wait until a signal arrives, and restore the set of blocked signals. */
int
-sigsuspend (set)
+__sigsuspend (set)
const sigset_t *set;
{
sigset_t oset;
@@ -49,3 +49,4 @@
__set_errno (save);
return -1;
}
+weak_alias (__sigsuspend, sigsuspend)
Index: sysdeps/mach/hurd/sigsuspend.c
===================================================================
RCS file: /egcs/carton/cvsfiles/libc/sysdeps/mach/hurd/sigsuspend.c,v
retrieving revision 1.20
diff -u -r1.20 sigsuspend.c
--- sigsuspend.c 1997/05/26 22:24:46 1.20
+++ sigsuspend.c 1998/07/19 23:03:45
@@ -1,4 +1,4 @@
-/* Copyright (C) 1991, 92, 93, 94, 95, 96, 97 Free Software Foundation, Inc.
+/* Copyright (C) 1991, 92, 93, 94, 95, 96, 97, 98 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -23,9 +23,8 @@
/* Change the set of blocked signals to SET,
wait until a signal arrives, and restore the set of blocked signals. */
-/* XXX should be __sigsuspend ? */
int
-sigsuspend (set)
+__sigsuspend (set)
const sigset_t *set;
{
struct hurd_sigstate *ss;
@@ -80,3 +79,4 @@
errno = EINTR;
return -1;
}
+weak_alias (__sigsuspend, sigsuspend)
Index: sysdeps/generic/sigsuspend.c
===================================================================
RCS file: /egcs/carton/cvsfiles/libc/sysdeps/generic/sigsuspend.c,v
retrieving revision 1.1
diff -u -r1.1 sigsuspend.c
--- sigsuspend.c 1997/10/13 03:52:37 1.1
+++ sigsuspend.c 1998/07/19 23:03:45
@@ -1,4 +1,4 @@
-/* Copyright (C) 1991, 1995, 1996, 1997 Free Software Foundation, Inc.
+/* Copyright (C) 1991, 95, 96, 97, 98 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -23,13 +23,14 @@
/* Change the set of blocked signals to SET,
wait until a signal arrives, and restore the set of blocked signals. */
int
-sigsuspend (set)
+__sigsuspend (set)
const sigset_t *set;
{
__set_errno (ENOSYS);
return -1;
}
+weak_alias (__sigsuspend, sigsuspend)
-
stub_warning (sigsuspend)
+stub_warning (__sigsuspend)
#include <stub-tag.h>