This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- From: Vineet Gupta <Vineet dot Gupta1 at synopsys dot com>
- To: Lukasz Majewski <lukma at denx dot de>
- Cc: Andreas Schwab <schwab at suse dot de>, "fweimer at redhat dot com" <fweimer at redhat dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "arnd at arndb dot de" <arnd at arndb dot de>, "palmerdabbelt at google dot com" <palmerdabbelt at google dot com>, "zongbox at gmail dot com" <zongbox at gmail dot com>, Alistair Francis <alistair dot francis at wdc dot com>, "adhemerval dot zanella at linaro dot org" <adhemerval dot zanella at linaro dot org>, "macro at wdc dot com" <macro at wdc dot com>, Alistair Francis <alistair23 at gmail dot com>, arcml <linux-snps-arc at lists dot infradead dot org>, "joseph at codesourcery dot com" <joseph at codesourcery dot com>
- Date: Thu, 20 Feb 2020 00:26:17 +0000
- Subject: Re: [RFC v6 07/23] RISC-V: Use 64-bit time_t and off_t for RV32 and RV64
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synopsys.com; dmarc=pass action=none header.from=synopsys.com; dkim=pass header.d=synopsys.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=radv2WN9lF7azjjmUlWI5gBd3mF+vtGZSaWc8MWfrmQ=; b=KbtODqMslXACv8zBGdQzb6k+qcb8QKiiU5yQs9fhOim4NlQdC9TrHRkvpiko9mHEr88ZtfRHmZ6l77Z6NEjUJWoLenFDxksJxC8A4OzqKx/fu/RM60++Gljg9MaYDfjeZVYGCByFt7ddGN5IoRqJ78l1zH9hisfl8KfshX6Sd2xNREXOLXWpwpWxJ2gbJMJaxhk6fkHCP4ZkYa3zyrCn68KC8Da7uhzt+1tqqFdIFgtPTTKfOGC2Rs3K7JsZWARHk9bx52weQirAr/jHj7NkoyHWy7hcbBXvVtXv21oKQysIMN92TzPn7dFL6M96mictxShcgsjaIYGg1itr08rNGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKI+p4SxExnihQUQef5KlqGlv/JliHnRRD9iQsUwYH21gZoeb9Hyebj6NWdLKrRqpKCQXCPXeLvfJ3dKD6n05UbvN28f23CnQIvwZJX+TTyt48iD87h7lvAiObUTPtafyl8sgJHaMxoHixATUdVVE5XTgw1DCShmhcTZdntx5P4Jw16e5FQigEqqgE2jci3NXC3km8NETA3sQk+t/0StbBFbf06+12vua0VPgiUvAQn77O0t+OqfRs09waDJ/1UaiLaDTQGM1vnQNrL7esVvQP5Asmhtn7GLLFwb5Z6IMyiK1dOYzaup/lDseFUVg3aCGl3MALtJpteEcx+rI3c3Bg==
- References: <cover.1578824547.git.alistair.francis@wdc.com> <4e95f95966d8d7c6a8339160dc62d81c1f6a1bfb.1578824547.git.alistair.francis@wdc.com> <67f2298c-30ab-1508-4a10-6ee285df7ad1@synopsys.com> <CAKmqyKO6u15cDbQQ644GrABi=6WWQsNLiCVLszrmDCdcWBnCPA@mail.gmail.com> <c9f11e9e-7c33-0000-e32c-346d425d7c69@synopsys.com> <mvmimk3567z.fsf@suse.de> <8239db87-d736-a6e2-913d-c1e5e937688f@synopsys.com> <20200220001822.703ee8a1@jawa>
Hi Lukasz,
On 2/19/20 3:18 PM, Lukasz Majewski wrote:
> Please keep in mind that there are some architectures (like 32 bit
> ARM), which are NOT using asm-generic API.
Right understand that.
> Those archs also require support for 64 bit time. That is why Alistair
> put the [sg]etitimer conversion code into sysdeps/unix/sysv/linux/
> directory.
>
> In that way all eligible archs could reuse the same conversion code.
Do note that the statx syscall to glibc stat64 interworking is already usable for
both cases as it is in sysdeps/unix/sysv/linux/statx_cp.*
Is see that for ARM32, following files are built:
sysdeps/unix/sysv/linux/arm/xstat.c
sysdeps/unix/sysv/linux/arm/fxstat.c
sysdeps/unix/sysv/linux/arm/lxstat.c
sysdeps/unix/sysv/linux/arm/fxstatat.c
sysdeps/unix/sysv/linux/xstat64.c
sysdeps/unix/sysv/linux/fxstat64.c
sysdeps/unix/sysv/linux/lxstat64.c
sysdeps/unix/sysv/linux/fxstatat64.c
My patch will switch the last 4 for ARM as well.
The first 4 will need more work as sym aliasing like
strong_alias (__xstat64, __xstat)
will be needed in those ARM files (which in turn use i386).
Anyhow, let me test my patch and then we can take it from there !
Thx,
-Vineet