This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] mips: Fix argument passing for inlined syscalls on Linux [BZ #25523]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: WANG Xuerui <git at xen0n dot name>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 10 Feb 2020 22:34:32 +0000
- Subject: Re: [PATCH] mips: Fix argument passing for inlined syscalls on Linux [BZ #25523]
- Ironport-sdr: 24CY+YO7x4Si2xBgtVyN1V+RQ9/DFgYIwpI6wF4ZzvpkpfgFplFhTXzj88kvl7jwY1sTewUCQQ DT7sxMYnUBu45yZBOJlMbaBicmkeRvWHiYt6kd2cztLS+lc82Kd/avGaw/KBnVbnPzyBQWcezV ogdYyfuSr18EGQC0wcVAe0qSNH+tKoC3BL9CPy7OU6Kz+IJTYvdfC6boEEpW5eFBaGOS0I8z// C+XLsg71/u9iyiM2qDje7OME9gVWkTt77iLLWTuULK9qc53glw5O9ncRS2yo7zIDMxaNgb4Ccb Lrg=
- Ironport-sdr: enrc7XgGleCVR7GRzBiyjT8g5AHWetE0/BV6qqIesJQkxsNoY2gOU01ZOIjN7o3b7eCLuw52yw g/OG2W5l4yFDkl14Lx6qJnUCZEz7Syp9DEMoV1MCG/13uT3WBho1e69x+u+enIuPuuajpOgLRy slgOD1xeqvwLySUty91trsgugF/6CfLDUM9TqeAhGvw8UsMdpGasXJ96YOTdEBxCxsPjuFG7lo WrDrGxZGS38YSI3/D/1vw1Q23fRTksE0Y0ifPdljuetscHcjgaaOT2Csv0NoH1/H4TwzTOKlX0 B4Y=
- References: <20200209185729.15896-1-git@xen0n.name>
On Mon, 10 Feb 2020, WANG Xuerui wrote:
> diff --git a/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h b/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h
> index beefcf284b..c275d63f67 100644
> --- a/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h
> +++ b/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h
> @@ -178,10 +178,11 @@ union __mips_syscall_return
> long _sys_result; \
> \
> { \
> + long _arg1 = (long) (arg1); \
The glibc style is to use "long int" in place of "long", so I think the
new variables should do that throughout the patch (and likewise "long long
int").
Please post a revised patch, and say if you need someone to commit it for
you.
--
Joseph S. Myers
joseph@codesourcery.com