This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [MIPS] Raise highest supported EI_ABIVERSION value


On Fri, 9 Aug 2019, Mihailo Stojanovic wrote:

> Hello everyone,
> 
> As suggested by Joseph here [1], this bumps the highest valid ABIVERSION
> value for ABSOLUTE ABI, which was, I suppose, overlooked by Maciej in
> [2].

Please see what I said there about either adding a testcase (that fails 
before and passes after the patch), or including an explanation in the 
proposed commit message of why this is hard enough to test in the 
testsuite that it's appropriate not to include a test.  (Stating "this 
fixes test X that is already in the testsuite" is also an option if true.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]