This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: V8 test-in-container patch


On Thu, 23 Aug 2018, DJ Delorie wrote:

> Joseph Myers <joseph@codesourcery.com> writes:
> > I expect that even if this build gets deferred to when the testsuite is 
> > run, you'll still need to use $(libunwind)
> 
> Sure, but I'm thinking it also might be a piece of the bootstrap puzzle
> that we don't (or shouldn't) need to worry about.
> 
> How's this patch look?  The various macros seem undocumented, but this
> looks like what the various test linkers are using.
> 
> diff --git a/support/Makefile b/support/Makefile
> index b5fcb6ed86..166420de70 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -165,18 +165,14 @@ ifeq (,$(CXX))
>  LINKS_DSO_PROGRAM = links-dso-program-c
>  else
>  LINKS_DSO_PROGRAM = links-dso-program
> -LDLIBS-links-dso-program = -lstdc++ -lgcc_s
> +LDLIBS-links-dso-program = -lstdc++ $(gnulib-tests)

I think the question there is whether the --as-needed in $(gnulib-tests) 
is an issue for this purpose (whether you want the libraries linked in 
even if not used for anything).  Maybe in this case it doesn't matter 
because the libraries in question will in fact always be used.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]