This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc64: Remove support for !HAVE_INLINED_SYSCALLS


On 08/20/2018 08:22 PM, Tulio Magno Quites Machado Filho wrote:
Florian Weimer <fweimer@redhat.com> writes:

On 08/20/2018 06:29 PM, Adhemerval Zanella wrote:


On 20/08/2018 11:40, Florian Weimer wrote:
HAVE_INLINED_SYSCALLS is always defined on Linux.

2018-08-20  Florian Weimer  <fweimer@redhat.com>

	* sysdeps/powerpc/powerpc64/dl-machine.h (DL_STARTING_UP_DEF):
	Remove macro.
	(RTLD_START): Adjust.

This file is not Linux specific, so it can potentially be used on a port
which defines HAVE_INLINED_SYSCALLS.  Is the plan to get rid of
HAVE_INLINED_SYSCALLS altogether?

Do you plan to start a Hurd port for powerpc? 8-)

I agree with Adhemerval here, even if there isn't a plan to port powerpc to
Hurd.  :-D
But I do agree to remove it if this is causing a problem for you (and an
explanation of the reason in the commit message ;-) ).

I'm trying to simplify the powerpc startup code, to align it more with what is done on other architectures. The additional preprocessor conditionals contribute to cognitive load when dealing with such changes.

This is related to the minimization patch for the startup code, but given the testing and review effort required for this patch anyway, I plan to go one step further and remove the always-NULL function arguments as well.

All in all, this should allow us to get rid of struct startup_info for new binaries.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]