Re: [PATCH] fnmatch: Use __mbstowcs_alloc [BZ #23519]

[Florian Weimer <fweimer at redhat dot com>]

On 08/17/2018 02:36 PM, Adhemerval Zanella wrote:
> On 14/08/2018 12:53, Florian Weimer wrote:
> > Sorry, I posted the wrong version of the patch.  Try this one.
>
> I think we should first address which should the desirable solution for
> BZ#14185: 1. reject as non-matching or give an error on invalid multibyte
> strings or 2. fallback on single-bye matching for these invalid entries.
> The second option is already on gnulib, so we can either first sync with
> it work to get it sync back (with the __mbstowcs_alloc). It might not be
> the best option though, as noted by Rich in comment #4 (it result false
> positives).

I don't think my proposed cleanup will interfere with these fixes at all 
(less code would have to be deleted), so I don't see the reason why to 
block it.

Thanks,
Florian