This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: verify the size of top chuck, stopping House of Force


On 08/16/2018 09:38 PM, Zack Weinberg wrote:
On Thu, Aug 16, 2018 at 3:29 PM, DJ Delorie <dj@redhat.com> wrote:

Florian Weimer <fweimer@redhat.com> writes:
DJ, will you apply this patch?  We do not need copyright assignment for
this.

Done.  Thanks!

Should we have a test case for this?  It doesn't look hard to write,
going by https://heap-exploitation.dhavalkapil.com/attacks/house_of_force.html

I don't think it's possible to create a valuable test case for this which will stop crashing once we regress the actual hardening. It's too likely that such a change would still crash the test, resulting in a false positive.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]