This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 16 Aug 2018 11:53:31 -0400
- Subject: Re: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags
- References: <20180704142954.4F54743994575@oldenburg.str.redhat.com> <09619f64-d2c6-45e8-7590-f45c75b74bc5@redhat.com>
On 08/14/2018 11:57 AM, Florian Weimer wrote:
> On 07/04/2018 04:29 PM, Florian Weimer wrote:
>> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
>> without also overriding essential flags such as -Wa,--noexecstack.
>>
>> 2018-07-04 Florian Weimer <fweimer@redhat.com>
>>
>> * Makeconfig (ASFLAGS): Always append required assembler flags.
>>
>> diff --git a/Makeconfig b/Makeconfig
>> index 608ffe648c..099f184088 100644
>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -1047,7 +1047,7 @@ endif
>> ifndef ASFLAGS
>> ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>> endif
>> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
This looks correct to me.
>> ifndef BUILD_CC
>> BUILD_CC = $(CC)
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.