This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 16 Aug 2018 10:00:07 -0300
- Subject: Re: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags
- References: <20180704142954.4F54743994575@oldenburg.str.redhat.com> <09619f64-d2c6-45e8-7590-f45c75b74bc5@redhat.com>
On Tue, 14 Aug 2018, Florian Weimer wrote:
>On 07/04/2018 04:29 PM, Florian Weimer wrote:
>> Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
>> without also overriding essential flags such as -Wa,--noexecstack.
I understood that this patch will let us set ASFLAGS from the
command-line. You mentioned CFLAGS because that's how we could indirectly
set ASFLAGS, right?
If so, looks good to me.
>> --- a/Makeconfig
>> +++ b/Makeconfig
>> @@ -1047,7 +1047,7 @@ endif
>> ifndef ASFLAGS
>> ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>> endif
>> -ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>> +override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
>>
>> ifndef BUILD_CC
>> BUILD_CC = $(CC)
>
>Ping?