This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 03/10] Improve performance of sinf and cosf


Joseph Myers wrote:

> The ulps updates here broke the testsuite build for x86_64 through adding
> invalid "ifloat:1" and "float:1" lines (missing space after colon) to 
> sysdeps/x86_64/fpu/libm-test-ulps.  I don't know quite how you generated 
> those changes to libm-test-ulps; "make regen-ulps" should never generate 
> such invalid lines, either before or after my move of it from perl to 
> python.

Sorry, it seems I copied and pasted some fields incorrectly. I've committed a
fix with the spaces, the libm-test-ulps is now identical to the latest regen output.

Wilco

    Fix spaces in x86_64 ULP file
    
    Fix a few missing spaces, it's now identical to the regenerated version.
    
    Passes GLIBC tests on x64.
    
ChangeLog:
2018-08-15  Wilco Dijkstra  <wdijkstr@arm.com>

        * sysdeps/x86_64/fpu/libm-test-ulps: Regenerate to fix spaces.
--
diff --git a/sysdeps/x86_64/fpu/libm-test-ulps b/sysdeps/x86_64/fpu/libm-test-ulps
index a51faecfc72342904d7c0ecb1ae90a03c14a7cad..e26f9c13586dc90bf7af42ca0994da3eb489ff45 100644
--- a/sysdeps/x86_64/fpu/libm-test-ulps
+++ b/sysdeps/x86_64/fpu/libm-test-ulps
@@ -2548,14 +2548,14 @@ double: 1
 float: 1
 float128: 3
 idouble: 1
-ifloat:1
+ifloat: 1
 ifloat128: 3
 ildouble: 3
 ldouble: 3
 
 Function: "sin_towardzero":
 double: 1
-float:1
+float: 1
 float128: 2
 idouble: 1
 ifloat: 1
@@ -2565,7 +2565,7 @@ ldouble: 2
 
 Function: "sin_upward":
 double: 1
-float:1
+float: 1
 float128: 3
 idouble: 1
 ifloat: 1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]