This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Makeconfig (ASFLAGS): Always append required assembler flags


On 07/04/2018 04:29 PM, Florian Weimer wrote:
Otherwise, it is impossible to set ASFLAGS differently from CFLAGS
without also overriding essential flags such as -Wa,--noexecstack.

2018-07-04  Florian Weimer  <fweimer@redhat.com>

	* Makeconfig (ASFLAGS): Always append required assembler flags.

diff --git a/Makeconfig b/Makeconfig
index 608ffe648c..099f184088 100644
--- a/Makeconfig
+++ b/Makeconfig
@@ -1047,7 +1047,7 @@ endif
  ifndef ASFLAGS
  ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
  endif
-ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
+override ASFLAGS += -Werror=undef $(ASFLAGS-config) $(asflags-cpu)
ifndef BUILD_CC
  BUILD_CC = $(CC)

Ping?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]