This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/3] Tests for argp/err/error functions with long double


While we were writing support for long double with IEEE binary128 format
for powerpc64le, Joseph pointed out that many functions from argp.h,
err.h, error.h are missing support for printing long double values with
double format, and expressed that fixing this would be desirable.

This patch set does not yet fix the lack of support, but it adds new
test cases that check that converting long double values to string works
correctly in the relevant functions.

Future patches will add the fix and reuse theses test cases.

(since this future fix is built on top of Zack's patches for
printf/scanf [1], I plan to address the problems already raised in their
review, then move forward with the fix (I already have it on a branch
[2]).  Afterwards, I'll work on the similar task for long double with
binary128 format on powerpc64le).

[1] https://sourceware.org/ml/libc-alpha/2018-03/msg00185.html

[2] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/gabriel/powerpc-ieee128-printscan
    More specifically, the fixes are (commit IDs):
      - cc98b0bef943
      - 3fb91ab64835
      - b13dc6eceb73
      - a165bbb66023
      - 5a90c1ef09ef
      - 525bfa87856c


Gabriel F. T. Gomes (3):
  Add tests for argp_error and argp_failure with floating-point
    parameters
  Add test for warn, warnx, vwarn, and vwarnx with floating-point
    parameters
  Add tests with floating-point arguments for err* and verr* functions

 argp/Makefile                       | 12 +++++++
 argp/tst-ldbl-argp-error.c          |  3 ++
 argp/tst-ldbl-argp-error.sh         | 46 +++++++++++++++++++++++++
 argp/tst-ldbl-argp-failure.c        |  3 ++
 argp/tst-ldbl-argp-failure.sh       | 45 ++++++++++++++++++++++++
 argp/tst-ldbl-argp-template.c       | 69 +++++++++++++++++++++++++++++++++++++
 misc/Makefile                       | 26 ++++++++++++++
 misc/tst-ldbl-error-err.c           |  3 ++
 misc/tst-ldbl-error-error.c         |  3 ++
 misc/tst-ldbl-error-error_at_line.c |  3 ++
 misc/tst-ldbl-error-errx.c          |  3 ++
 misc/tst-ldbl-error-template.c      | 45 ++++++++++++++++++++++++
 misc/tst-ldbl-error-verr.c          |  3 ++
 misc/tst-ldbl-error-verrx.c         |  3 ++
 misc/tst-ldbl-error.sh              | 52 ++++++++++++++++++++++++++++
 misc/tst-ldbl-warn.c                | 61 ++++++++++++++++++++++++++++++++
 misc/tst-ldbl-warn.sh               | 48 ++++++++++++++++++++++++++
 17 files changed, 428 insertions(+)
 create mode 100644 argp/tst-ldbl-argp-error.c
 create mode 100644 argp/tst-ldbl-argp-error.sh
 create mode 100644 argp/tst-ldbl-argp-failure.c
 create mode 100644 argp/tst-ldbl-argp-failure.sh
 create mode 100644 argp/tst-ldbl-argp-template.c
 create mode 100644 misc/tst-ldbl-error-err.c
 create mode 100644 misc/tst-ldbl-error-error.c
 create mode 100644 misc/tst-ldbl-error-error_at_line.c
 create mode 100644 misc/tst-ldbl-error-errx.c
 create mode 100644 misc/tst-ldbl-error-template.c
 create mode 100644 misc/tst-ldbl-error-verr.c
 create mode 100644 misc/tst-ldbl-error-verrx.c
 create mode 100644 misc/tst-ldbl-error.sh
 create mode 100644 misc/tst-ldbl-warn.c
 create mode 100644 misc/tst-ldbl-warn.sh

-- 
2.14.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]