This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reduce the statically linked startup code [BZ #23323]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 8 Aug 2018 08:10:08 -0700
- Subject: Re: [PATCH] Reduce the statically linked startup code [BZ #23323]
- References: <20180623214525.CB496402DFEF9@oldenburg.str.redhat.com> <edc80e57-356a-dc28-6195-f4508410c8ab@redhat.com>
On Wed, Aug 8, 2018 at 7:48 AM, Florian Weimer <fweimer@redhat.com> wrote:
> This is the patch rebased for glibc 2.29.
>
> Should we make more far-reaching changes and remove the arguments which are
> now zero?
>
i386 and x86-64 parts look good, except for
+ /* These used to be the addresses of .fini and .init. */
+ xor %R8_LP, %R8_LP
+ xor %RCX_LP, %RCX_LP
Please use
xorl %r8d, %r8d
xorl %ecx, %ecx
They will zero-extend to 64 bits.
Thanks.
--
H.J.