This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] conform/conformtest.pl: Escape literal braces in regular expressions
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 6 Jul 2018 10:26:32 -0400
- Subject: Re: [PATCH] conform/conformtest.pl: Escape literal braces in regular expressions
- References: <20180706132927.DA37843994575@oldenburg.str.redhat.com>
On 07/06/2018 09:29 AM, Florian Weimer wrote:
> This suppresses Perl warnings like these:
>
> Unescaped left brace in regex is deprecated here (and will be fatal in
> Perl 5.32), passed through in regex; marked by <-- HERE in m/^element
> *({ <-- HERE ([^}]*)}|([^{ ]*)) *({([^}]*)}|([^{ ]*)) *([A-Za-z0-9_]*)
> *(.*)/ at conformtest.pl line 370.
>
> 2018-07-06 Florian Weimer <fweimer@redhat.com>
>
> * conform/conformtest.pl (checknamespace): Escape literal braces
> in regular expressions.
Please commit.
You should feel free to check something like this in without review,
particularly if it fixes a direct warning. If someone wants to rewrite
this in python, or in a different way in perl, then they can always
follow up with another patch.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.