This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace hidden_def with libm_hidden_def in math
Joseph Myers <joseph@codesourcery.com> writes:
> [ text/plain ]
> On Fri, 27 Apr 2018, Tulio Magno Quites Machado Filho wrote:
>
>> libm_hidden_def expand the parameters and do not require an extra layer
>> of macros.
>> These were the last 3 files in math/ still using hidden_def().
>>
>> 2018-04-27 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>>
>> * math/w_exp_compat.c: Replace hidden_def with libm_hidden_def..
>> * math/w_expl_compat.c: Likewise.
>> * math/w_exp_template.c: Likewise. Remove hidden_def_x.
>
> OK, but without the change
>
>> diff --git a/math/w_expl_compat.c b/math/w_expl_compat.c
>> index dda930405e..4e80ce82e3 100644
>> --- a/math/w_expl_compat.c
>> +++ b/math/w_expl_compat.c
>> @@ -22,6 +22,7 @@ static char rcsid[] = "$NetBSD: $";
>> * wrapper expl(x)
>> */
>>
>> +#include <libc-symbols.h>
>
> (libc-symbols.h is automatically included via "-include
> $(..)include/libc-symbols.h" from Makeconfig, you should never need to
> include it explicitly).
Fixed and pushed as dc115e1cdc36.
Thanks!
--
Tulio Magno