This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/6] Remove slow paths from sin/cos
On Fri, 9 Mar 2018, Wilco Dijkstra wrote:
> +#else
> + /* Disable warning... */
> + n = 0, n = n;
> + a = 0, a = a;
> + da = 0, da = da;
> #endif
I don't think we should use this approach for warning avoidance - rather,
the variable declarations should be conditioned appropriately, or if
what's conditional is whether the variables are used or only set, there
should be conditional __attribute__ ((unused)) on the declarations.
(I realise patch 6 would remove this code, but think each patch should
leave the tree in a sensible state - especially given patch 6 is evidently
one of the more controversial pieces of this series.)
> +#else
> + /* Disable warning... */
> + n = 0, n = n;
> #endif
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com