This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Define GEN_AS_CONST_HEADERS when generating header files [BZ #22792]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 21 Feb 2018 08:09:38 +0100
- Subject: Re: [PATCH] Define GEN_AS_CONST_HEADERS when generating header files [BZ #22792]
- Authentication-results: sourceware.org; auth=none
- References: <20180208175818.GA8519@gmail.com>
On 02/08/2018 06:58 PM, H.J. Lu wrote:
[BZ #22792]
* Makerules ($(common-objpfx)%.h): Pass -DGEN_AS_CONST_HEADERS
to $(CC).
* sysdeps/unix/sysv/linux/i386/lowlevellock.h: Include
<tcb-offsets.h> only if GEN_AS_CONST_HEADERS isn't defined.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Don't include
<tcb-offsets.h>.
It looks to me that a cleaner fix would be to move the definition of the
TCB types to a separate header.
The circular dependency is just a cosmetic warning from make, right?
Thanks,
Florian