This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] ldconfig: Call fsync on temporary files before renaming them [BZ #20890]
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 20 Feb 2018 11:02:58 -0300
- Subject: Re: [PATCH] ldconfig: Call fsync on temporary files before renaming them [BZ #20890]
- Authentication-results: sourceware.org; auth=none
- References: <20180112110757.D4D2440172552@oldenburg.str.redhat.com> <65555278-8167-d0a5-2ec6-e0f2c812c703@cs.ucla.edu> <a179f76a-be9c-1d4b-f117-230bd1ac4f8d@redhat.com> <883f519e-bbf9-faa2-565f-83455359edba@redhat.com>
On 20/02/2018 10:59, Florian Weimer wrote:
> On 01/19/2018 05:39 PM, Florian Weimer wrote:
>> 2018-01-12 Florian Weimer<fweimer@redhat.com>
>>
>> [BZ #20890]
>> * elf/cache.c (save_cache): Call fsync on temporary file before
>> renaming it.
>> (save_aux_cache): Call fdatasync on temporary file before renaming
>> it.
>
> Ping?
LGTM.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> <https://sourceware.org/ml/libc-alpha/2018-01/msg00660.html>
>
> Thanks,
> Florian