This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h

From: Zack Weinberg <zackw at panix dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 5 Feb 2018 16:43:28 -0500
Subject: Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
Authentication-results: sourceware.org; auth=none
References: <20180205122807.GA12157@gmail.com> <CAKCAbMg746E4ZFGQdkNZM1QHA-d2PwdST-YcJ933+xyAtXpvdQ@mail.gmail.com> <CAMe9rOrQLNuREfn8TH6hSMY+Xq-5ZL1w9nRO83kqGUow4Pbqug@mail.gmail.com>

On Mon, Feb 5, 2018 at 3:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Although they are equivalent, GCC treats
>
> if (__builtin_expect (map->l_mach.plt, 0) == 0)
>
> slightly differently from
>
> if (__glibc_likely (map->l_mach.plt == 0))
>
> such that the outputs aren't identical.

Thanks for the clarification.

zw

References:
- [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
  - From: H.J. Lu
- Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
  - From: Zack Weinberg
- Re: [PATCH] i386: Use __glibc_likely/__glibc_likely in dl-machine.h
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]