This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] LIBC_SLIBDIR_RTLDDIR: substitute arguments in single quotes
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, libc-alpha at sourceware dot org
- Date: Thu, 25 Jan 2018 08:10:03 -0800
- Subject: Re: [PATCH] LIBC_SLIBDIR_RTLDDIR: substitute arguments in single quotes
- Authentication-results: sourceware.org; auth=none
- References: <mvmefmeqmuz.fsf@suse.de>
On 01/25/2018 02:00 AM, Andreas Schwab wrote:
> The arguments of the LIBC_SLIBDIR_RTLDDIR macro are used both in unquoted
> and single quoted context, so that neither shell nor makefile variable
> references work. Consistently put them in single quotes so that they can
> refer to makefile variables.
> ---
> ChangeLog | 14 ++++++++++++++
> aclocal.m4 | 4 ++--
> sysdeps/gnu/configure | 4 ++--
> sysdeps/unix/sysv/linux/aarch64/configure | 4 ++--
> sysdeps/unix/sysv/linux/mips/configure | 8 ++++----
> sysdeps/unix/sysv/linux/powerpc/powerpc64/configure | 4 ++--
> sysdeps/unix/sysv/linux/s390/s390-64/configure | 4 ++--
> sysdeps/unix/sysv/linux/sparc/sparc64/configure | 4 ++--
> sysdeps/unix/sysv/linux/tile/configure | 4 ++--
> sysdeps/unix/sysv/linux/x86_64/64/configure | 4 ++--
> sysdeps/unix/sysv/linux/x86_64/x32/configure | 4 ++--
> 11 files changed, 36 insertions(+), 22 deletions(-)
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.