This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]

On Wed, 24 Jan 2018, Carlos O'Donell wrote:

> I have finished analyzing this and debugging the root cause myself,
> and I agree with Florian, we need to revert:
> 
> commit f81ddabffd76ac9dd600b02adbf3e1dac4bb10ec
> commit cba595c350e52194e10c0006732e1991e3d0803b
> 
> At a minimum. I am testing with them reverted locally.
> 
> To be honest I'm surprised that this passed review and was checked
> in, because the __pthread_unwind_buf_t has only at most 4-bytes of

It didn't pass review.  It was checked in with no evidence of consensus 
(and even with ABI concerns raised in the original discussion).

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]