This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/7] stdlib: Optimization qsort{_r} swap implementation

On Mon, 22 Jan 2018, Adhemerval Zanella wrote:
> On 22/01/2018 06:27, Paul Eggert wrote:
> > Adhemerval Zanella wrote:
> >> +static inline bool
> >> +check_alignment (const void *base, size_t align)
> >> +{
> >> +  return _STRING_ARCH_unaligned || ((uintptr_t)base % (align - 1)) == 0;
> >> +}
> > 
> > Surely the '(align - 1)' was supposed to be 'align'. Has this been tested on an architecture that does not allow unaligned access?
> 
> Yes, I checked on sparc64 machine.  This test is similar to the Linux kernel one
> at lib/sort.c.

But the kernel source correctly uses '&' there rather than '%'.

Alexander
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]