This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]

From: Carlos O'Donell <carlos at redhat dot com>
To: Arjun Shankar <arjun dot is at lostca dot se>, libc-alpha at sourceware dot org
Date: Tue, 16 Jan 2018 14:56:22 -0800
Subject: Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]
Authentication-results: sourceware.org; auth=none
References: <20180104170250.GA72870@aloka.lostca.se> <2933759f-89f6-9a4d-e249-0d740e02c3bc@redhat.com>

On 01/16/2018 02:31 PM, Carlos O'Donell wrote:
> Please rewrite this as:
> 
> #define foo(...) \
> ({			\
> 	...		\
> })
> 
> The nested braces are less verbose IMHO.

Note that requeset2size (above) can't use nested braces because
it's involved in constant sized array expressions outside
of a normal function.

-- 
Cheers,
Carlos.

References:
- [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]
  - From: Arjun Shankar
- Re: [PATCH] Fix integer overflows in internal memalign and malloc functions [BZ #22343]
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]