This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] aarch64: Update bits/hwcap.h for Linux 4.15.
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: nd at arm dot com, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 15 Jan 2018 17:17:45 +0000
- Subject: Re: [PATCH] aarch64: Update bits/hwcap.h for Linux 4.15.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <5A5CA700.90604@arm.com> <5DBDBB97-B519-4624-8BC8-35BFEBDE7C9E@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 15/01/18 16:57, Alan Hayward wrote:
>> On 15 Jan 2018, at 13:05, Szabolcs Nagy <Szabolcs.Nagy@arm.com> wrote:
>>
>> Define new HWCAP bits and add their name to dl-procinfo.c following
>> the linux definitions. Synchronizing with v4.15-rc8 version of linux,
>> these are not expected to change before the 4.15 release.
>>
>> (Will commit this tomorrow unless there are complaints.)
>>
>> 2018-01-15 Szabolcs Nagy <szabolcs.nagy@arm.com>
>>
>> * sysdeps/unix/sysv/linux/aarch64/bits/hwcap.h (HWCAP_SHA3): Define.
>> (HWCAP_SM3, HWCAP_SM4, HWCAP_ASIMDDP, HWCAP_SHA512, HWCAP_SVE): Define.
>> * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.c
>> (_dl_aarch64_cap_flags): Update.
>> * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h
>> (_DL_HWCAP_COUNT): Update.
>> <hwcap.diff>
>
> Quickly comparing the the patch I had attempt myself….
>
> I think the 16 here needs updating:
> PROCINFO_CLASS const char _dl_aarch64_cap_flags[16][10]
>
thanks for catching this.
(i'll change the code so it's less dangerous:
only one macro should be updated)
> And this needs updating too:
> #define _DL_HWCAP_LAST 15
i will remove this macro.