This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 08/17] RISC-V: Generic <math.h> and soft-fp Routines
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, <patches at groups dot riscv dot org>
- Date: Mon, 15 Jan 2018 16:59:06 +0000
- Subject: Re: [PATCH v4 08/17] RISC-V: Generic <math.h> and soft-fp Routines
- Authentication-results: sourceware.org; auth=none
- References: <20180113103816.4861-1-palmer@dabbelt.com> <20180113103816.4861-9-palmer@dabbelt.com>
On Sat, 13 Jan 2018, Palmer Dabbelt wrote:
> This patch contains the miscellaneous math routines and headers we have
> implemented for RISC-V. This includes things from <math.h> that aren't
> completely ISA-generic, floating-point bit manipulation, and soft-fp
> hooks.
>
> FIXME: add ieee745/soft-fp via a riscv/soft-fp directory.
Again, it should be a riscv/nofpu directory, and riscv/soft-fp shouldn't
exist.
> diff --git a/sysdeps/riscv/math-tests.h b/sysdeps/riscv/math-tests.h
> +#define EXCEPTION_TESTS_float 0
> +#define EXCEPTION_TESTS_double 0
> +#define EXCEPTION_TESTS_long_double 0
I'd expect that to be conditional on soft-float, as exceptions should be
supported for hard-float (whether the hard-float or soft-float ABI is
used). I'd also expect ROUNDING_TESTS_* to be defined to ((MODE) ==
FE_TONEAREST) for soft-float, as on other architectures, given that
rounding modes are only supported for hard-float.
--
Joseph S. Myers
joseph@codesourcery.com