This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 11 Jan 2018 19:32:45 -0800
- Subject: Re: [PATCH] libnsl: Do not install libnsl.so, libnsl.a if NIS is disabled [BZ #22701]
- Authentication-results: sourceware.org; auth=none
- References: <20180111182159.2E32B4070C60A@oldenburg.str.redhat.com>
On 01/11/2018 10:21 AM, Florian Weimer wrote:
> This also skips building the .o files for libnsl.a.
>
> 2018-01-11 Florian Weimer <fweimer@redhat.com>
>
> * nis/Makefile (install-lib-ldscripts, $(inst_libdir)/libnsl.so):
> Prevent installation of libnsl.so.
> (libnsl-inhibit-o): Do not build (or install) static libraries.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> diff --git a/nis/Makefile b/nis/Makefile
> index b828c5ec4d..702c31eb63 100644
> --- a/nis/Makefile
> +++ b/nis/Makefile
> @@ -69,7 +69,15 @@ libnss_nis-inhibit-o = $(filter-out .os,$(object-suffixes))
> libnss_nisplus-routines := $(addprefix nisplus-,$(databases)) nisplus-parser \
> nss-nisplus nisplus-initgroups
> libnss_nisplus-inhibit-o = $(filter-out .os,$(object-suffixes))
> -endif
> +
> +else # not $(build-obsolete-nsl)
> +# Pretend that libnsl.so is a linker script, so that the symbolic link
> +# is not installed.
> +install-lib-ldscripts = libnsl.so
> +$(inst_libdir)/libnsl.so:
> +libnsl-inhibit-o = .o # Build no static libnsl.a.
> +
> +endif # not $(build-obsolete-nsl)
>
> include ../Rules
>
>
--
Cheers,
Carlos.