This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 13/18] hppa: Add memcopy.h

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>, Richard Henderson <rth at twiddle dot net>
Date: Thu, 11 Jan 2018 13:36:43 +0000
Subject: Re: [PATCH v3 13/18] hppa: Add memcopy.h
Authentication-results: sourceware.org; auth=none
References: <1515588482-15744-1-git-send-email-adhemerval.zanella@linaro.org> <1515588482-15744-14-git-send-email-adhemerval.zanella@linaro.org>

On Wed, 10 Jan 2018, Adhemerval Zanella wrote:

> +extern void link_error(void);

Missing space before '('.

> +static inline op_t
> +MERGE(op_t w0, int shl, op_t w1, int shr)

Likewise.

> +  if (OPSIZ == 4)
> +    asm("shrpw %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
> +  else if (OPSIZ == 8)
> +    asm("shrpd %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
> +  else
> +    link_error(), res = 0;

Likewise, after asm, and after link_error, and after strings in asm.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v3 13/18] hppa: Add memcopy.h
  - From: Adhemerval Zanella

References:
- [PATCH v3 00/18] Improve generic string routines
  - From: Adhemerval Zanella
- [PATCH v3 13/18] hppa: Add memcopy.h
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]