This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]

From: Florian Weimer <fweimer at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, Andreas Schwab <schwab at suse dot de>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 9 Jan 2018 11:47:12 +0100
Subject: Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]
Authentication-results: sourceware.org; auth=none
References: <20171207174057.GA32196@gmail.com> <7e890f53-c331-d86e-ad13-b380a69d99eb@redhat.com> <CAMe9rOrBtpjUsXcnbnFMZi5dc46RWvRd6cMH3qnSFbHbprkvZg@mail.gmail.com> <814691a7-d946-1794-d6d8-7861f9ed2067@redhat.com> <CAMe9rOqYvgRYifxq8CGFsBCGcVS0FAcoa+gwZ5m4CyMQVpTWWg@mail.gmail.com> <08cf7c54-8bf0-27c0-863a-65cb76dd0728@redhat.com> <CAMe9rOp2V3ZkdfwCyO6c7-574sQHNdkMiUC1JVtvAZwanbTsow@mail.gmail.com> <CAMe9rOqkygr2gvrr6wjV-s0NEaw5juDyx9eju352C0wRb2_r2A@mail.gmail.com> <e7e3e22f-2bf7-eb69-e114-ae4352d816bb@redhat.com> <CAMe9rOqiSm6GfuXCAwL3zuuRO5mzdMtx3MkrxBpdgSC0nNCghw@mail.gmail.com> <4e80a87a-c90a-85a6-daf1-cbbf71d0bf58@redhat.com> <CAMe9rOpWgWPpM0pJ4nJ-8rN=merNXuSw8RaX_UfWsMeBN2gbJg@mail.gmail.com> <e9828d0b-675f-2608-7170-53aef29aae27@redhat.com> <CAMe9rOpKb8rBLL4LYnKZKBQY-6nZs51Hhwp8Xwk6KW8wwFVzrQ@mail.gmail.com> <CAMe9rOoqU7Tp7+H_cU4d7KOdEkuj6gLB2eR1LFgA2kqFge6wBQ@mail.gmail.com> <mvmmv2ghz87.fsf@suse.de> <CAMe9rOr6Lh3HQb7APjvbQWcC4kGf30Z9Vp2LVQhF_54b4PxkRA@mail.gmail.com>

On 12/18/2017 03:48 PM, H.J. Lu wrote:

On Mon, Dec 18, 2017 at 6:44 AM, Andreas Schwab <schwab@suse.de> wrote:

On Dez 18 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:

This patch adds bits/types/__cancel_jmp_buf_tag.h to define struct
__cancel_jmp_buf_tag so that Linux/x86 can add saved_mask to
cancel_jmp_buf.


Isn't that an ABI change?


Yes, this change is exposed to application via <phread.h>.  The backward
binary compatibility is provided by

https://sourceware.org/ml/libc-alpha/2017-12/msg00208.html


This doesn't seem to work:

<https://sourceware.org/ml/libc-alpha/2018-01/msg00178.html>

I have no idea what is going on, but if we can't find the root cause, Ithink we should revert all the setjmp changes.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]
  - From: H.J. Lu
- Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]
  - From: Aurelien Jarno

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]