This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #11787] Fix stack guard size accounting
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com
- Date: Mon, 8 Jan 2018 07:37:09 -0800
- Subject: Re: [PATCH][BZ #11787] Fix stack guard size accounting
- Authentication-results: sourceware.org; auth=none
- References: <5A2FE5ED.1080300@arm.com> <eef573ca-9685-7c45-5ed9-f2c5aeaa62ea@redhat.com> <7a6cf3bb-3b98-e66f-0d8d-a3a9c73a528d@redhat.com>
On 01/08/2018 07:22 AM, Florian Weimer wrote:
>> * Second patch removed the unused pthread_attr_r and renames __pthread_get_minstack
>> to avoid usage by other programs.
>
> The proposed second patch *still* breaks Rust programs with large
> static TLS data because it will switch to PTHREAD_STACK_MIN. We
> should do this only after __pthread_get_minstack turns constant (that
> is, returns PTHREAD_STACK_MIN).
I had not considered that.
Yes, applications are basically working around bug 11787 by calling
__ptrhead_get_minstack.
Perhaps you are right, until we disentangle TLS, such applications
need the workaround.
OK, I'm happy with the patch going in as-is then, and leaving the
second half of the cleanup until later.
--
Cheers,
Carlos.