Re: [PATCH 1/3] linux: move a shared part of sys/ptrace.h to bits/ptrace-shared.h

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 29/12/2017 11:18, Dmitry V. Levin wrote:
> On Fri, Dec 29, 2017 at 11:07:39AM -0200, Adhemerval Zanella wrote:
>> On 27/12/2017 01:46, Dmitry V. Levin wrote:
>>> Move a shared part of sys/ptrace.h which is the same on all
>>> architectures to a separate file.
>>>
>>> * sysdeps/unix/sysv/linux/sys/ptrace.h: Include <bits/ptrace-shared.h>.
>>> (__ptrace_setoptions, __ptrace_eventcodes, __ptrace_peeksiginfo_args,
>>> __ptrace_peeksiginfo_flags, ptrace): Move to ...
>>> * sysdeps/unix/sysv/linux/bits/ptrace-shared.h: ... new file.
>>> * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Add
>>> bits/ptrace-shared.h.
>>> * sysdeps/unix/sysv/linux/aarch64/sys/ptrace.h: Include
>>> <bits/ptrace-shared.h>.
>>> (__ptrace_setoptions, __ptrace_eventcodes, __ptrace_peeksiginfo_args,
>>> __ptrace_peeksiginfo_flags, ptrace): Remove.
>>> * sysdeps/unix/sysv/linux/ia64/sys/ptrace.h: Likewise.
>>> * sysdeps/unix/sysv/linux/powerpc/sys/ptrace.h: Likewise.
>>> * sysdeps/unix/sysv/linux/s390/sys/ptrace.h: Likewise.
>>> * sysdeps/unix/sysv/linux/sparc/sys/ptrace.h: Likewise.
>>> * sysdeps/unix/sysv/linux/tile/sys/ptrace.h: Likewise.
>>
>> I assume you have checked for any build failures on the affected architectures.
>> I have just a nit below regarding copyright dates, otherwise looks ok.
> 
> Thanks.
> 
> [...]
>>> diff --git a/sysdeps/unix/sysv/linux/bits/ptrace-shared.h b/sysdeps/unix/sysv/linux/bits/ptrace-shared.h
>>> new file mode 100644
>>> index 0000000..98ed335
>>> --- /dev/null
>>> +++ b/sysdeps/unix/sysv/linux/bits/ptrace-shared.h
>>> @@ -0,0 +1,78 @@
>>> +/* `ptrace' debugger support interface.  Linux version,
>>> +   not architecture-specific.
>>> +   Copyright (C) 1996-2017 Free Software Foundation, Inc.
>>
>> I am not sure if we should retroactively set the copyright for consolidation
>> code (it was not the case for some internal pthread consolidation).
> 
> bits/ptrace-shared.h file is essentially a copy of sys/ptrace.h with
> __ptrace_request removed, this way it inherited the copyright notice, too.
> 
> Do we reset copyright years in such cases?

I am trying to see if there is a guideline regarding it, but I can't find any
documentation. In any case, you patch seems a conservative approach and should do
no harm. LGTM.

Attachment: signature.asc
Description: OpenPGP digital signature