This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/3] elf: remove is_path related redundant code


On Wed, Dec 20, 2017 at 09:21:00PM +0100, Aurelien Jarno wrote:
> On 2017-12-20 16:42, Dmitry V. Levin wrote:
> > The only place in the code nowadays that specifies is_path == 1 argument
> > is fillin_rpath, and the string being passed in that case never contains ':'
> > symbols.  This makes the whole is_path thing redundant.
> > 
> > Dmitry V. Levin (3):
> >   elf: remove redundant code from _dl_dst_substitute
> >   elf: remove redundant code from is_dst
> >   elf: remove redundant is_path argument
> > 
> >  ChangeLog                  | 15 ++++++++++++
> >  elf/dl-deps.c              |  4 +--
> >  elf/dl-dst.h               |  4 +--
> >  elf/dl-load.c              | 61 ++++++++++++++--------------------------------
> >  sysdeps/generic/ldsodefs.h |  4 +--
> >  5 files changed, 39 insertions(+), 49 deletions(-)
> 
> This looks all good to me, thanks for the cleanup.

Committed.


-- 
ldv

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]