This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Proposal: Deprecate direct access stdio internals (for future hard removal)
On Fri, Dec 22, 2017 at 8:31 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 12/22/2017 05:24 PM, Zack Weinberg wrote:
>>
>> I abstractly support this change. I wonder what the consequences for
>> binaries using the "old" stdio (glibc 2.0-format struct _IO_FILE,
>> _IO_old_*) will be.
>
> I looked at this and we should be able to force the inlined C code on slow
> paths if we always keep _IO_read_ptr == _IO_read_end and _IO_write_ptr ==
> _IO_write_end. We would have to add some code to the functions on the
> public interface to recognize the _IO_stdin &c variables (some care is
> needed to take copy relocations into account) and substitute them with the
> official stdin &c variables. This doesn't look too cumbersome.
Sounds fine by me, then.
>> I would also like to draw your attention to my patch to stop
>> installing libio.h
>> [https://sourceware.org/ml/libc-alpha/2017-08/msg01200.html], which
>> has not received any review or testing or any reaction at all, in
>> fact. :-/
>
> Do we want to put this into 2.27? I can still try to review it.
I was hoping someone would do an archive rebuild and find out whether
there's any current software that needs the header; it might be better
as 2.28 material at this point. A deprecation #warning might be
feasible for 2.27, though. In any case your review would be most
welcome.
zw