This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/3] Cleanup __ieee754_sqrt(f/l)
Joseph Myers wrote:
> It's not being defined, it's being 1 rather than 0 (#if, not #ifdef).
> You should use _Float128, not __float128; bits/floatn.h handles defining
> _Float128 as a typedef if necessary for older compilers.
OK I can get that to work, but I still get odd issues with sqrtf128 being
called from the testsuite, while libm.so only defines __sqrtf128, so it
gives undefined symbol errors on x64. So I wonder whether in external
headers we should never do this:
#define sqrtl sqrtf128
Unless there is an easy fix for these issues, I can't see any point in
including it in my current patches - improving float/double inlining in this
release gives much more benefit to all targets.
Wilco