This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, <dj at redhat dot com>
- Date: Wed, 20 Dec 2017 16:50:48 +0000
- Subject: Re: [PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines
- Authentication-results: sourceware.org; auth=none
- References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-7-palmer@dabbelt.com>
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> +#ifndef __riscv_flen
> +
> +#define _FPU_RESERVED 0xffffffff
Missing preprocessor indentation, "# define" etc. inside #if (except for
the #if of a header's multiple-include guard). Likewise generally in lots
of places in this patch.
> +#define _FCLASS_MINF (1<<0)
GNU style would use (1 << 0) with spaces around <<; likewise elsewhere in
this patch.
--
Joseph S. Myers
joseph@codesourcery.com