This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [hurd,commited] hurd: Fix rtld link


Hi!

On Fri, 15 Dec 2017 17:48:42 +0100, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote:
> > On Sun,  3 Sep 2017 04:33:45 +0200, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > > --- a/sysdeps/mach/hurd/dl-sysdep.c
> > > +++ b/sysdeps/mach/hurd/dl-sysdep.c
> > 
> > > +int weak_function
> > > +__access_noerrno (const char *file, int type)
> > > +{
> > > +  errno = ENOSYS;
> > > +  return -1;
> > > +}
> 
> D'oh...

;-)

Pushed:

commit d232f2e137127139addde487f0f01881b52cc446
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Dec 15 17:00:50 2017 +0100

    Don't set errno in Hurd rtld's __access_noerrno
    
            * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set
            errno.
    
    Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.
    
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
 ChangeLog                     | 5 +++++
 sysdeps/mach/hurd/dl-sysdep.c | 1 -
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git ChangeLog ChangeLog
index 00161628c5..027f948ec9 100644
--- ChangeLog
+++ ChangeLog
@@ -1,3 +1,8 @@
+2017-12-15  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set
+	errno.
+
 2017-12-15  Joseph Myers  <joseph@codesourcery.com>
 
 	* scripts/build-many-glibcs.py (Context.add_all_configs): Use
diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c
index 2cc342ec8e..5121ce325c 100644
--- sysdeps/mach/hurd/dl-sysdep.c
+++ sysdeps/mach/hurd/dl-sysdep.c
@@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);
 int weak_function
 __access_noerrno (const char *file, int type)
 {
-  errno = ENOSYS;
   return -1;
 }
 


Grüße
 Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]