This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/19] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)

From: Phil Blundell <pb at pbcl dot net>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Date: Mon, 11 Dec 2017 21:03:12 +0000
Subject: Re: [PATCH 08/19] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
Authentication-results: sourceware.org; auth=none
References: <1513019223-7603-1-git-send-email-adhemerval.zanella@linaro.org> <1513019223-7603-9-git-send-email-adhemerval.zanella@linaro.org> <1513023369.10295.1.camel@pbcl.net> <87shchj9eu.fsf@linux-m68k.org>

On Mon, 2017-12-11 at 21:29 +0100, Andreas Schwab wrote:
> On Dez 11 2017, Phil Blundell <pb@pbcl.net> wrote:
> 
> > On Mon, 2017-12-11 at 17:06 -0200, Adhemerval Zanella wrote:
> > > +1:
> > > +	mov	lr, pc
> > > +	b	__syscall_do_cancel
> > > +       .fnend
> > > +END (__syscall_cancel_arch)
> > 
> > I'm not sure I quite understand what's going on here.  Where is
> > __syscall_do_cancel() supposed to be returning to?
> 
> It never returns.

Right, that's sort of what I thought.  So why set up lr here?

p.

References:
- [PATCH 00/19] nptl: Fix Race conditions in pthread cancellation (BZ#12683)
  - From: Adhemerval Zanella
- [PATCH 08/19] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
  - From: Adhemerval Zanella
- Re: [PATCH 08/19] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
  - From: Phil Blundell
- Re: [PATCH 08/19] nptl: arm: Fix Race conditions in pthread cancellation (BZ#12683)
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]