This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] string: Replace = with += in CFLAGS-tst-xbzero-opt.c


On Mon, Dec 11, 2017 at 5:39 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
>
>> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
>>> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>>>
>>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>>>> to define CFLAGS-tst-xbzero-opt.c.
>>>>
>>>> Any comments?
>>>>
>>>> H.J.
>>>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>>>
>>> I think that should be done for all such assignments.
>>>
>>
>> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
>> string/Makefile?
>
> Everywhere, if you like to work on that.

I am checking in this patch to cover string/Makefile.  I will submit a
separate patch for */Makefile.


-- 
H.J.
From 9f0006a8825b6f1baae948f08cdf01d1e5277e51 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 11 Dec 2017 04:18:24 -0800
Subject: [PATCH] string: Replace = with += in CFLAGS-xxx.c

Replace = with += in CFLAGS-xxx.c to allow Makefile under sysdeps to
define CFLAGS-xx.c.

	* string/Makefile (CFLAGS-inl-tester.c): Replace = with +=.
	(CFLAGS-noinl-tester.c): Likewise.
	(CFLAGS-tst-strlen.c): Likewise.
	(CFLAGS-stratcliff.c): Likewise.
	(CFLAGS-test-ffs.c): Likewise.
	(CFLAGS-tst-inlcall.c): Likewise.
	(CFLAGS-tst-xbzero-opt.c): Likewise.
	(CFLAGS-memcpy.c): Likewise.
	(CFLAGS-wordcopy.c): Likewise.
---
 string/Makefile | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/string/Makefile b/string/Makefile
index d7e90a38a5..74ba4f2f76 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -69,13 +69,13 @@ endif
 
 include ../Rules
 
-CFLAGS-inl-tester.c = -fno-builtin
-CFLAGS-noinl-tester.c = -fno-builtin
-CFLAGS-tst-strlen.c = -fno-builtin
-CFLAGS-stratcliff.c = -fno-builtin
-CFLAGS-test-ffs.c = -fno-builtin
-CFLAGS-tst-inlcall.c = -fno-builtin
-CFLAGS-tst-xbzero-opt.c = -O3
+CFLAGS-inl-tester.c += -fno-builtin
+CFLAGS-noinl-tester.c += -fno-builtin
+CFLAGS-tst-strlen.c += -fno-builtin
+CFLAGS-stratcliff.c += -fno-builtin
+CFLAGS-test-ffs.c += -fno-builtin
+CFLAGS-tst-inlcall.c += -fno-builtin
+CFLAGS-tst-xbzero-opt.c += -O3
 # BZ 21006: Resolve all functions but at least explicit_bzero at startup.
 # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is
 # done by loading r4 / r5 with the test_pattern and using store multiple
@@ -86,8 +86,8 @@ CFLAGS-tst-xbzero-opt.c = -O3
 LDFLAGS-tst-xbzero-opt = -z now
 
 # Called during TLS initialization.
-CFLAGS-memcpy.c = $(no-stack-protector)
-CFLAGS-wordcopy.c = $(no-stack-protector)
+CFLAGS-memcpy.c += $(no-stack-protector)
+CFLAGS-wordcopy.c += $(no-stack-protector)
 
 ifeq ($(run-built-tests),yes)
 $(objpfx)tst-svc-cmp.out: tst-svc.expect $(objpfx)tst-svc.out
-- 
2.14.3


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]